Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aggregate ST_3DUnion #683

Merged
merged 3 commits into from
Apr 15, 2022
Merged

aggregate ST_3DUnion #683

merged 3 commits into from
Apr 15, 2022

Conversation

mngr777
Copy link
Contributor

@mngr777 mngr777 commented Apr 12, 2022

Adding aggregate ST_3DUnion on postgis_sfcgal extension creation; documentation update.

@robe2
Copy link
Member

robe2 commented Apr 13, 2022

I think this should read 3.3.0 instead of 3.0.0. Probably better to also just have it on it's own line

+ <para>Availability: 2.2.0, aggregate variant: 3.0.0</para>

like

+ <para>Availability: 3.3.0 aggregate variant was added</para>

@robe2
Copy link
Member

robe2 commented Apr 13, 2022

Added trac ticket here - https://trac.osgeo.org/postgis/ticket/5132 and testing out on windows before merge.

@robe2
Copy link
Member

robe2 commented Apr 13, 2022

Oh wait just realized we are missing tests for this. Can you add a test to sfcgal/regress/regress_sfcgal.sql

@strk strk closed this in b39f921 Apr 15, 2022
@strk strk merged commit b39f921 into postgis:master Apr 15, 2022
@robe2 robe2 removed the to merge label Apr 15, 2022
@mngr777 mngr777 deleted the aggregate-3dunion branch May 14, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants